search

TechnicJelle / BlueMapCustomSkinProvider

Minecraft Paper plugin and BlueMap addon for using a custom skin server with BlueMap
Mozilla Public License 2.0
1 stars 4 forks source link

Add {UUID-} placeholder #5

Closed XenWayne closed 2 months ago

XenWayne commented 2 months ago

4

TechnicJelle commented 2 months ago

If you add this placeholder in the config https://github.com/TechnicJelle/BlueMapCustomSkinProvider/blob/main/src/main/resources/config.yml and explain what it does there, then I'll merge this :+1:

I feel the current two placeholders are self-explanatory enough but "{UUID-}" is less so

XenWayne commented 2 months ago

So I added a description of {UUID-} in the latest commit : )

TechnicJelle commented 2 months ago

Yep, I just tested it locally and it works. Thank you for this contribution!

TechnicJelle commented 2 months ago

If I might ask, though, could you give an example of one such skin API that doesn't support dashes in the UUID? I'm kind of curious now. I've only really ever worked with Minotar and Crafatar, myself. And both of those support normal dashed UUIDs.

XenWayne commented 2 months ago

ok,I can explain that，so basically I'm testing a local skinserver which stores skin files locally.As we all know,dashed UUID is hard to index for database,especially for large amounts of data,so the primary key in the database is the UUID without dashes.The API is also implemented in this style,thouth it can be solved by changing API design,it's easier to change the way to request :)

If you are interested, feel free to visit the document for the whole project,(well that is writen in Chinese,Sorry for the inconvenience)