Closed weihao closed 2 years ago
Which versions of Minecraft, Paper, Geyser, and Floodgate are you using? Then I'll try and see if I can replicate this issue myself
1.18.1
Paper
This server is running Paper version git-Paper-81 (MC: 1.18.1) (Implementing API version 1.18.1-R0.1-SNAPSHOT) (Git: 8c189d0)
You are running the latest version
Previous version: git-Paper-79 (MC: 1.18.1)
Geyser-Velocity https://ci.opencollab.dev/job/GeyserMC/job/Geyser/job/master/957/
Floodgate-Velocity https://ci.opencollab.dev/job/GeyserMC/job/Floodgate/job/master/53/
You're using Floodgate for Velocity, not Spigot?
That's right
I am able to reproduce this everytime I join in BE.
I have absolutely no experience with Velocity at all, and I have zero idea how it works, so if I can't reproduce this error with the Spigot version, I'm afraid I can't really do much. If that is the case, maybe someone else can fix it in a PR, or if I ever start using Velocity myself, I'll see if I can fix it then. But first! I'm going to see if I can reproduce it with the Spigot version soon.
By the way, another small question that may or may not be related: Did you change BlueMap's default webroot in any way? Cause at the moment, the plugin doesn't support different webroots and your issue here made me remember that I completely forgot to update that, which I'll definitely need to do (tracking that in #6)
# Default is "bluemap/web"
webroot: "bluemap/web"
Okay, so it's not that problem. Too bad, because that would have been an easy fix, haha! We're looking into it! (No ETA, though)
shouldn't the playerheads be overwritten to $webroot/assets/playerheads/?
why are you overwriting it to plugins/BlueMapFloodgate/playerheads/
?
For caching purposes. BlueMapFloodgate only gets the playerhead once every three days (by default; changeable in the config). It then stores it in its own plugin folder and every time someone joins, it replaces BlueMap's playerhead with a copy from BlueMapFloodgate's cache.
On a slightly unrelated note, could you please also list all the plugins on the backend Minecraft server?
AdvancedTeleport, BlueBridgeCore, BlueBridgeGP, BlueMap, Chunky, CoreProtect, CreativeManager, DiscordSRV, floodgate, Gamemode-Change, GriefPrevention, Harbor, LuckPerms, PrometheusExporter, SpigotPing, UltimateAutoRestart, Vault, WorldEdit, WorldGuard
Okay, good news! I can reproduce this error myself without Velocity, just on a normal Paper server. This means I'll be able to diagnose it and hopefully fix it myself. I can't do that right now, because I've got quite a lot to do at the moment, but I'll try to work on it somewhere in the next week(end) or so Thanks for trying out my plugin and for reporting this bug!
It sure does, yep! I believe this to indeed be the problem at hand. I'll need to figure out a way to get that fixed up. I've asked in the Geyser support Discord for the new way of getting the textureID from the xuid, so I hope that'll be answered soon and I can start thinking about how to implement it.
I don't know if you already have a fix for this but it seems like the GeyserMC developers have deprecated v1 from their API and v2 is the one that is used now. In v2, they have slightly modified the JSON and removed the data key from it. I have made the necessary changes in my fork, and from my own testing, my modification seems to work fine. You can download it in the actions tab or the releases page.
I had indeed already found the fix, I just hadn't gotten around to implementing it, so thanks a lot for doing that! I'll merge it, if you don't mind :)
@weihao, the fix has been included in the newest release! And thanks again to @lebestnoob for fixing it so quickly!
You're welcome!