search

TechnicJelle / BlueMapOfflinePlayerMarkers

Minecraft Paper plugin and BlueMap addon that adds markers where players have logged off
Mozilla Public License 2.0
14 stars 8 forks source link

Un-hardcoded config #18

Closed LOOHP closed 1 year ago

LOOHP commented 1 year ago

This PR makes the config editable Closes #8 Closes #10 Closes #13

TechnicJelle commented 1 year ago

Please also write in the PR text which issues this closes :)

TechnicJelle commented 1 year ago

Also, if possible, add in a config.yml version checker, so the plugin can detect if it was updated from an older version and can alert the user that the config should be updated. Example of this: https://github.com/TechnicJelle/BlueMapFloodgate/blob/main/src/main/java/com/technicjelle/bluemapfloodgate/Main.java#L73, but if you have a better way for doing this kind of thing, by all means :D

LOOHP commented 1 year ago

Also, if possible, add in a config.yml version checker, so the plugin can detect if it was updated from an older version and can alert the user that the config should be updated. Example of this: https://github.com/TechnicJelle/BlueMapFloodgate/blob/main/src/main/java/com/technicjelle/bluemapfloodgate/Main.java#L73, but if you have a better way for doing this kind of thing, by all means :D

I feel like the config is small enough for now that this isn't needed (at least for the near future as well)

TechnicJelle commented 1 year ago

I feel like the config is small enough for now that this isn't needed (at least for the near future as well)

That's fair, for now, yeah, I suppose..

TechnicJelle commented 1 year ago

Just tested it out and it works nicely. Thank you very much for your contribution! :D