search

TechnicJelle / BlueMapOfflinePlayerMarkers

Minecraft Paper plugin and BlueMap addon that adds markers where players have logged off
Mozilla Public License 2.0
14 stars 8 forks source link

Server with online-mode disabled shows markers incorrectly #29

Closed BuIlDaLiBlE closed 1 year ago

BuIlDaLiBlE commented 1 year ago

There seems to be a problem displaying the markers when skins cannot be found. Take a look at my map: https://bpnet.work/bluemap. I do get "doesn't have a skin" for every player in the game as the server is in offline mode, but I have SkinsRestorer plugin so maybe it's possible to integrate the plugin with that or at least show the default Steve heads? :X

TechnicJelle commented 1 year ago

This plugin uses BlueMap's own skin grabber to get the skins, which you can override with a plugin like BlueMap Custom Skin Provider, for example. I don't think anyone has made a plugin that adds SkinsRestorer functionality to BlueMap, yet. If that ever gets made, then this plugin should automatically use that (if you install it, of course). As for falling back on a Steve head, it should already be doing that. In fact, if I look at your map, I can see that it indeed tries to use the steve.png: image But it can't find it... Which I just realised is indeed a bug! You have your server on /bluemap, so the steve.png for you is at https://bpnet.work/bluemap/assets/steve.png, while the plugin is looking for it in https://bpnet.work/assets/steve.png I'll fix that :)

TechnicJelle commented 1 year ago

Fixed the Steve head fallback not working on BlueMaps hosted on a subdirectory of a website in 74616f27c3dec642da9d97eb460402da9372e441 You can download it here: https://github.com/TechnicJelle/BlueMapOfflinePlayerMarkers/releases/tag/v2.5 Thanks for the bug report! :)