search

TechnicPack / TechnicSolder

PHP web app that brings differential updates to the Technic Launcher and Technic Platform
https://docs.solder.io/
Other
169 stars 167 forks source link

Rehashing not working as expected #545

Closed skwerlman closed 3 years ago

skwerlman commented 8 years ago

If you rehash any mod version, solder rehashes the topmost entry instead.

Before rehashing:

After rehashing 0.3.1.33 (the second entry):

Possibly related to #479

heddendorp commented 8 years ago

Although I'm not really sure this solves the issue, https://github.com/TechnicPack/TechnicSolder/blob/master/app/controllers/ModController.php#L170-L190 THe above lines make me think, if a mod was to be rehashed and the original file changed, the rehash wouldn't work, but use the one supplied in the input field again.

GenPage commented 8 years ago

@Isigiel Ping me on discord to discuss this further.

(See: https://github.com/TechnicPack/TechnicSolder/issues/469#issuecomment-143926031)

Pyker commented 4 years ago

This is fixed in https://github.com/TechnicPack/TechnicSolder/commit/37e8858e81e5ded50f791cd49c223b6d7c579969 (feature/laravel-6 branch)