TechnicPack / TechnicSolder

PHP web app that brings differential updates to the Technic Launcher and Technic Platform
https://docs.solder.io/
Other
169 stars 167 forks source link

Update to Laravel 8 #697

Closed HAV0C101 closed 2 years ago

HAV0C101 commented 3 years ago

697

Fixes # Updates to Laravel 8

Updated Laravel version and tidied up some code along the way Only issue as of current is i cant get any of the unit tests to work they just clear the database as soon as i run them so no test data gets added and all the tests fail from all db query's returning null, i will keep working on this but i have also tested the whole app extensively beyond these tests as well

phit commented 3 years ago

then with all the stylistic changes out of the way, why did you remove e.g. laravelcollective/html and redid all the forms?

HAV0C101 commented 3 years ago

then with all the stylistic changes out of the way, why did you remove e.g. laravelcollective/html and redid all the forms?

Seemed like a more cleaner way of doing them to me and also removed an unnessacery dependency