search

TechnicPack / TechnicSolder

PHP web app that brings differential updates to the Technic Launcher and Technic Platform
https://docs.solder.io/
Other
169 stars 167 forks source link

Config option to disable rate limit for certain users #703

Closed kmecpp closed 2 years ago

kmecpp commented 2 years ago

Laravel has a built in rate limiter which Solder uses and makes it annoying to programmatically manage modpacks. It would be great if there was a config option to disable this rate limit for certain users: https://stackoverflow.com/questions/43058219/disable-rate-limiter-in-laravel

Pyker commented 2 years ago

There is no authenticated api, and there are no plans to make it authenticated.

Pyker commented 2 years ago

If the rate limit is an issue for you, you can adjust it in the config.

kmecpp commented 2 years ago

Disabling the rate limiter for everyone isn't ideal. Couldn't something like this work fine where you just check if the user is logged in and specified in the config, and if so, skip the rate limit check? It's unrelated to the API

Pyker commented 2 years ago

No, that wouldn't work.