search

Technica-Engineering / kalash

Test runner made for scalable automation based on standard Python's `unittest`
GNU General Public License v3.0
3 stars 0 forks source link

Feature/7 8 schemas and json #10

Closed kjczarne closed 2 years ago

kjczarne commented 2 years ago

Resolves #8

All I did in the end was slight refactoring where from_yaml method name would reference both methods that load from a file as well as from a parsed YAML object. I refactored the object-related methods as from_yaml_obj and Trigger.from_yaml is now Trigger.from_file to indicate that it also accepts JSON input.

As @kayoub5 mentioned, the PyYAML lib loads JSON just as well.

codecov-commenter commented 2 years ago

Codecov Report

Merging #10 (cc562f3) into develop (180e054) will not change coverage. The diff coverage is 90.00%.

Impacted file tree graph

@@           Coverage Diff            @@
##           develop      #10   +/-   ##
========================================
  Coverage    76.08%   76.08%           
========================================
  Files           14       14           
  Lines          803      803           
========================================
  Hits           611      611           
  Misses         192      192
Impacted Files Coverage Δ
kalash/run.py 48.91% <66.66%> (ø)
kalash/collectors.py 91.42% <100.00%> (ø)
kalash/config.py 92.02% <100.00%> (ø)
kalash/filter.py 63.15% <100.00%> (ø)

Continue to review full report at Codecov.

Legend - Click here to learn more Δ = absolute <relative> (impact), ø = not affected, ? = missing data Powered by Codecov. Last update 180e054...cc562f3. Read the comment docs.