Closed kjczarne closed 2 years ago
Merging #10 (cc562f3) into develop (180e054) will not change coverage. The diff coverage is
90.00%
.
@@ Coverage Diff @@
## develop #10 +/- ##
========================================
Coverage 76.08% 76.08%
========================================
Files 14 14
Lines 803 803
========================================
Hits 611 611
Misses 192 192
Impacted Files | Coverage Δ | |
---|---|---|
kalash/run.py | 48.91% <66.66%> (ø) |
|
kalash/collectors.py | 91.42% <100.00%> (ø) |
|
kalash/config.py | 92.02% <100.00%> (ø) |
|
kalash/filter.py | 63.15% <100.00%> (ø) |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update 180e054...cc562f3. Read the comment docs.
Resolves #8
All I did in the end was slight refactoring where
from_yaml
method name would reference both methods that load from a file as well as from a parsed YAML object. I refactored the object-related methods asfrom_yaml_obj
andTrigger.from_yaml
is nowTrigger.from_file
to indicate that it also accepts JSON input.As @kayoub5 mentioned, the PyYAML lib loads JSON just as well.