Open kjczarne opened 2 years ago
Merging #22 (19058aa) into develop (cdd6488) will decrease coverage by
1.50%
. The diff coverage is74.16%
.
@@ Coverage Diff @@
## develop #22 +/- ##
===========================================
- Coverage 76.83% 75.32% -1.51%
===========================================
Files 14 15 +1
Lines 833 912 +79
===========================================
+ Hits 640 687 +47
- Misses 193 225 +32
Impacted Files | Coverage Δ | |
---|---|---|
kalash/run.py | 46.46% <7.69%> (-2.74%) |
:arrow_down: |
kalash/filter.py | 63.79% <66.66%> (ø) |
|
kalash/interpolation.py | 68.18% <68.18%> (ø) |
|
kalash/model.py | 88.52% <72.97%> (ø) |
|
kalash/utils.py | 93.33% <90.90%> (-6.67%) |
:arrow_down: |
kalash/collectors.py | 91.66% <100.00%> (ø) |
|
kalash/kalash_test_loader.py | 89.18% <100.00%> (ø) |
|
kalash/log.py | 91.20% <100.00%> (-2.70%) |
:arrow_down: |
kalash/metaparser.py | 92.10% <100.00%> (ø) |
|
kalash/spec.py | 97.43% <100.00%> (-2.57%) |
:arrow_down: |
... and 3 more |
Continue to review full report at Codecov.
Legend - Click here to learn more
Δ = absolute <relative> (impact)
,ø = not affected
,? = missing data
Powered by Codecov. Last update cdd6488...19058aa. Read the comment docs.
TODO:
CliConfig
classThis MR will partly solve #17 as well
List all Issues this Pull Request is meant to solve:
Run through our contribution checklist:
kalash/doc/contributing.md
?nox -e json_schema
, only if you did anything with the data model)?nox -e test
)?flake8
)?CHANGELOG.md
?Describe shortly the changes you have introduced:
logging
interface, there is no need to wrap anything in my opinion. The global logger is a bit lower level since it will be predominantly used by the developers.internal-config.yaml
. At the moment configuration preload is not happening at runtime because the scope of this change was just the logger but I needed the internal config for some smart handling of defaults that can be configured as per project. Users now have more control over how the per-test-case logs are grouped and how the file logs are named.Add additional comments (if any): The checklist is incomplete because I'll run through the rest for a number of tickets at once.