Expand all runAtLocation methods to support chunk coordinate arguments

TechnicallyCoded / FoliaLib

This is a wrapper library for aiding in supporting the Folia Paper Fork. This library adds multiple scheduler options to use instead of the Bukkit or Folia native schedulers.

MIT License

70 stars 11 forks source link

Expand all runAtLocation methods to support chunk coordinate arguments #20

Closed xGinko closed 4 months ago

xGinko commented 5 months ago

Closes #11

Adds support for passing in world and chunk coordinates for all runAtLocation methods.

CJCrafter commented 5 months ago

Hey xGinko, typically this developer likes to merge PRs into dev, not main. TechnicallyCoded handles all merges from dev into main then... Can you change the branch to dev?

xGinko commented 5 months ago

yo @CJCrafter thanks for pointing me in the right direction

TechnicallyCoded commented 5 months ago

Hey @xGinko , thank you for contributing!

As you noticed, we requested a few changes, so there 2 main things that need changing before accepting this:

If you can address these pointers we gave you directly in the code review
Please move all the runAtChunk methods together instead of intertwined with the runAtLocation methods, the same way all the runAsync and runAtEntity are grouped together

TechnicallyCoded commented 4 months ago

@xGinko Should we keep this open?

xGinko commented 4 months ago

@TechnicallyCoded I'll make a new one