search

TechnicallyCoded / Inventory-Rollback-Plus

Spigot/Bukkit plugin that allows server moderators to restore player items and data from backups.
https://www.spigotmc.org/resources/85811/
Other
78 stars 44 forks source link

How do the plugin handle player death #162

Open broken1arrow opened 3 months ago

broken1arrow commented 3 months ago

I have notes some players have problems when using Inventory-Rollback-Plus and death-chest. I can't say what the reason is behind it clear the inventory. But I did try to change the listener priory, but your plugin seams to lessen at a higher level than I set.

So how do this plugin handle player death, so I could adjust the logic?

MrKioZ commented 3 months ago

Yea i am have the same issue with me and i am using Angel Chest plugin in combination with this plugin could be the cause of issue that angel chest handles the event before this plugin i dont know

TechnicallyCoded commented 3 months ago

@broken1arrow https://github.com/TechnicallyCoded/Inventory-Rollback-Plus/issues/162#issue-2453522692

During the death event you have the ability to clear the drops list without clearing the player's inventory.

List#clear() on the following should work: https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/event/entity/EntityDeathEvent.html#getDrops()

broken1arrow commented 3 months ago

@broken1arrow #162 (comment)

During the death event you have the ability to clear the drops list without clearing the player's inventory.

List#clear() on the following should work: https://hub.spigotmc.org/javadocs/bukkit/org/bukkit/event/entity/EntityDeathEvent.html#getDrops()

I aware of that option. But the author as decided to clear player slots, he only check the drop list in the code for some specific checks.

And change the priority should have done something.

But will check out if that option could be used instead of clear the inventory.

TechnicallyCoded commented 3 months ago

Please bring the author into this conversation, I can't bring back deleted data. Just not possible.

TylorTurner commented 3 months ago

Any solution yet with angelchest? I currently do not have any deaths either.

WaxenSs commented 3 months ago

@TylorTurner For the moment, no. The developers are working on it together, so let's give them some time Enable notifications for this issue to check its status :)

JRGrim commented 3 months ago

Any solution yet with angelchest? I currently do not have any deaths either.

mfnalex (angelchest's creator) added a fix long time ago https://github.com/TechnicallyCoded/Inventory-Rollback-Plus/issues/146#issuecomment-1886598122