search

TechnicallyCoded / Inventory-Rollback-Plus

Spigot/Bukkit plugin that allows server moderators to restore player items and data from backups.
https://www.spigotmc.org/resources/85811/
Other
78 stars 44 forks source link

Issue | Performance impact. #35

Closed plushycat closed 3 years ago

plushycat commented 3 years ago

Hey, this is an issue we're facing on our network during peak hours where actions from inventory rollback caused lag spikes/tps dip. Here are the attached spark timings for reference. https://spark.lucko.me/rdEhT1PY2i https://spark.lucko.me/njsPI0MUQV It also was recommended by one of my staff members to add in an async onjoin save inventory task.

TechnicallyCoded commented 3 years ago

One of your timing (spark) reports show that some of your tick lag is originating from player heads. (I might be wrong about that, it seems to be running in a async task... forget about that).

The lag related to IRP (using MySQL) has been fixed in the dev branch, however I must wait to see if this is stable enough to release :)

You are welcome to compile that version and give feedback related to any issues you encounter!

TechnicallyCoded commented 3 years ago

An update resolving your issue has been pushed to spigot :) Thanks for your report!

(issue will be closed in about a week)