search

TechnicallyCoded / Inventory-Rollback-Plus

Spigot/Bukkit plugin that allows server moderators to restore player items and data from backups.
https://www.spigotmc.org/resources/85811/
Other
78 stars 44 forks source link

Can't set time zone to EST #56

Closed Wolfcoool closed 2 years ago

Wolfcoool commented 2 years ago

Bug description:

When setting EST, EDT, or ET under "time-zone" in config.yml, I get this warning: [11:17:04 WARN]: [InventoryRollbackPlus] Time zone "EST" in config.yml is invalid. Defaulting to "UTC" UTC-5 also does not work.

Server details:

TechnicallyCoded commented 2 years ago

The built-in timezone handling from java is pretty bad. I have thought of re-writing this stuff manually to make it more reliable but haven't gotten around to it due to some limitations of doing so.

TechnicallyCoded commented 2 years ago

Just as a note: when I use this system it seems to work fine for me. This could indicate an issue with what java version you are using? I don't really know.

Wolfcoool commented 2 years ago

Setting EST works fine for you? I'm on java 17, btw.

TechnicallyCoded commented 2 years ago

Ok, it seems that the settings actually applies correctly but still throws a error/ warning in the console. Have you checked the in-game menus for what time is listed?

Wolfcoool commented 2 years ago

(GitHub didn't notify me about your response, sorry)

Just checked and like you said, yes it does work but throws an error. Seems like you fixed it with that commit though, thank you!