search

TechnicallyCoded / Inventory-Rollback-Plus

Spigot/Bukkit plugin that allows server moderators to restore player items and data from backups.
https://www.spigotmc.org/resources/85811/
Other
78 stars 44 forks source link

Bug report: Plugin disabling itself on restarts and stucks there. #64

Closed NotSharwan closed 2 years ago

NotSharwan commented 2 years ago

Bug description:

The inventoryrollbackplus plugin disables itself and becomes stuck whenever the server restarts. Even the console and memory usage are stuck, so if we clear the inventory data of players saved by this plugin, then only it works on the next restart. Otherwise, it gets stuck and disables on every restart.

Server details:

How to reproduce:

Happens every restart!

What was expected:

It is expected to work without stuck and disabling.

Screenshots, logs & other:

https://i.imgur.com/aer2r1G.png https://mcpaste.io/56217a3969641bab

Additional info:

N/A

TechnicallyCoded commented 2 years ago

What do you mean by a restart? Shutting the server down breaks too? or necessarily restarting the server? Have you tried removing the plugin temporarily and trying the same operation again? You are mentioning a restart, what happens if you just run /stop?

TechnicallyCoded commented 2 years ago

Additional info: the plugin almost doesn't do anything on disable other than deleting a stored value in RAM in case you are doing /reload or using a plugin manager to reload the plugin. That's it, just preventing a possible error / memory leak. The method it's running on shutdown: image The second thing it runs on shutdown: image So I really don't see how that could ever make a server hang.

NotSharwan commented 2 years ago

The console and memory usage are stuck after this line [InventoryRollbackPlus] Disabling InventoryRollbackPlus v1.6.5 It happens every restart, our server restart every 2 hours, and it stucks. We need to clear the inventory data of players saved by this plugin to get the thing work properly. Not really able to understand why exactly that is happening. If you stop, and start the server, the issue remains the same.

Edit : We use the Pebal Hosting server, which has a control panel for starting/restarting/stopping. Stopping the server yields the same results; the server must be killed, which is a force stop, before it can be restarted. This hang/stuck is resolved when all player save data is deleted, implying that it is related to items in the player's inventory. It causes hang when the inventory is saved as player disconnects during restart.

TechnicallyCoded commented 2 years ago

Can you try removing the plugin and do the same thing that made it hang? I'll check the method for player disconnection in a bit to see if there is anything that could block it but the server would hang when the player disconnects, not when disabling the plugin.

NotSharwan commented 2 years ago

The plugin has already been removed, and no issues or hangs have been observed since then.

TechnicallyCoded commented 2 years ago

Very peculiar... As you know, thousands of people use the plugin and this is the first report of this type I have seen. Unfortunate to say, but I think that this is one of the situations where something in your setup just doesn't line up with my code in some odd way and I have no idea what to do about it nor what to recommend be changed on your end :/

TechnicallyCoded commented 2 years ago

Do you have a testing server that you can replicate this issue on? Or was only that one server?

TechnicallyCoded commented 2 years ago

No additional information?

NotSharwan commented 2 years ago

Please accept my apologies for the delayed response! We've had the plugin removed for a while now and haven't had any disabling issues. When we add it again, it disables everything after a while and stops at [InventoryRollbackPlus] Disabling InventoryRollbackPlus v1.6.5. I'm not sure what's going on here. Also, I can't replicate on the test server because the shutdown issue occurs suddenly after using the plugin for about 2-3 days. If we delete the backup data for the save inventories, it will work properly on the next restart.

TechnicallyCoded commented 2 years ago

"it disables everything after a while"

  1. I really would like to get the FULL server logs on this one.
  2. What is shutting down the server? It makes no sense as to why the server would just stop...
  3. What server host are you using?

If you don't want to provide your entire server logs to the public I can understand that, so I can add you on discord if you prefer providing your discord tag.

NotSharwan commented 2 years ago

Yes, when the server reboots. It begins disabling all plugins and hangs until it reaches the message [InventoryRollbackPlus] Disabling InventoryRollbackPlus v1.6.5.

  1. In the report, I already mentioned the log - https://mcpaste.io/56217a3969641bab
  2. The shutting down triggers at scheduled restarts, it saves the gave and starts disabling the plugins.
  3. https://pebblehost.com/

I'm not sure why this disabling occurs, but it causes the server to hang and requires a staff member to manually restart it from the panel. The only solution we found was to temporarily disable the plugin, which solved the problem; we apologise for the inconvenience. My discord tag: Shxrwan#0001