Technici4n / Modern-Dynamics

Modern item and fluid transport Minecraft mod.
GNU Lesser General Public License v3.0
21 stars 14 forks source link

Excessive amount of item transfer will lead to client connection failure #65

Closed aria1th closed 1 year ago

aria1th commented 1 year ago

Mods like https://github.com/AztechMC/Modern-Industrialization requires tremendous amount of item transfer (with visualization). But, basically packets from item transport will bottleneck client network connection, and will lead to client connection failure (TCP Reset).

We need packet limit config per network to prevent those cases.

Technici4n commented 1 year ago

Hi, can you provide a client profile (/sparkc) so I can see what's so slow with the client's handling?

aria1th commented 1 year ago

https://spark.lucko.me/TT7qG2MwWo Here is it, I reduced amount of transfer until It was 'okay'

aria1th commented 1 year ago

Also I observed significant lag on server side, here is server report: https://spark.lucko.me/9KsUS0g25m

Technici4n commented 1 year ago

Oh damn, TR storage units strike again... :/

aria1th commented 1 year ago

In fact, I reduced its packet amount to 1/20 and it was laggy too..., but with modern dynamic's pipe, I can confirm it was sending 2700 packet / second

Technici4n commented 1 year ago

Server side needs optimizations on TR's end. Client side is very easy to fix for me, the pipes are recomputing their shape needlessly and that's very expensive. Should be fixed this week.

Technici4n commented 1 year ago

I just released version 0.4.1-beta (will be out in a few minutes), let me know if that helps with the issue on the client side.