Technici4n / Modern-Dynamics

Modern item and fluid transport Minecraft mod.
GNU Lesser General Public License v3.0
20 stars 12 forks source link

Incompatibility with yarn development environments #73

Closed MattiDragon closed 1 year ago

MattiDragon commented 1 year ago

Modern dynamics is currently incompatible with mod development environments using yarn due to a remapping conflict. It seems like the fix is to simply rename a single method. I encountered this while investigating a bug report that might be related to this mod.

CableSlot has a method called isEnabled that's used for checks all over them mod, including the isActive override on the same class. The issue arises when an attempt is made to remap modern dynamics to yarn because the yarn name for isActive is isEnabled. So, because the signatures match exactly we'd end up with two of the same method (returning the same values in this case, but not always). This causes fabric loader to abort the remapping as it should. Renaming the method or simply moving it to isActive should fix this.

Logs