Technici4n / Powah

Discussion on the AE2 Discord server:
https://discord.gg/Zd6t9ka7ne
GNU Lesser General Public License v3.0
29 stars 23 forks source link

Power generation artificially delayed, producing less than advertised #146

Open yurikus opened 5 months ago

yurikus commented 5 months ago

Version: (make sure you are on the latest version before reporting):

Config values are set to generate 8K FE/t, single player world.

Issue description:

Power generation artificially delayed, producing less than advertised. See video repro below. You will find a spirited magmator trash canning energy with flux plug. Advertised generation is 8K FE/t, while real is 5K FE/t. Latter value is an average of alternation between 2K and 8K: (8+2)/2=5. due to an artificial 2 or 4 thick delay in the sync method.

https://github.com/Technici4n/Powah/blob/62b7f556959c413ebb94236e9beb9b373672b1a8/common/src/main/java/owmii/powah/block/magmator/MagmatorTile.java#L70

Below is the delay computation. https://github.com/Technici4n/Powah/blob/62b7f556959c413ebb94236e9beb9b373672b1a8/common/src/main/java/owmii/powah/lib/block/AbstractTickableTile.java#L62-L64

...

Steps to reproduce:

https://youtu.be/XshM95DUrV0 ...

yurikus commented 5 months ago

~Same~ SImilar issue, ~misdiagnosed~: #50, here I think you're correct the 100mb overrides the choice

Nitro magmator exhibits the same alternation issue with general.magmatic_fluids.lava = 100_000: https://youtu.be/HrdIv16ShsA

With that value set to 1M, we get steady 40K FE/t