search

Technickel-Dev / low-poly

Low Poly is a React based website that takes advantage of WASM to generate digital art inspired by low poly art styles.
https://lowpoly.tripleresolution.com/
MIT License
6 stars 5 forks source link

Add debounce to drawing #23

Closed faddalibrahim closed 2 years ago

faddalibrahim commented 2 years ago

added a debounce of 1.5s. I don't know if it's from my side, but the image manipulation following the debounce takes longer. test if from your end and let's see

BzvB4U8Zq5

netlify[bot] commented 2 years ago

✔️ Deploy Preview for low-poly ready!

🔨 Explore the source changes: 997a65913a6e363fd30af09e8316b6744963ed19

🔍 Inspect the deploy log: https://app.netlify.com/sites/low-poly/deploys/61d09dd261fea40007fc107b

😎 Browse the preview: https://deploy-preview-23--low-poly.netlify.app/

Technickel-Dev commented 2 years ago

Another fantastic piece of work! Thank you! I tried it out on my end and it seems alright time wise. I think the debounce makes it feel like the image manipulation is taking longer but it's really that it waits 1.5s for debounce and then the image manipulation takes another 2-3s to do its thing.

We can always lower the debounce time in the future if needed but I think the big thing it needs is a spinner letting the user know that some thinking is going on when the image manipulation kicks in. I'll make a new issue for it for the future.

faddalibrahim commented 2 years ago

alright. I get it👌