TechnikEmpire / CitadelCore

Cross platform filtering HTTP/S proxy based on .NET Standard 2.0.
Mozilla Public License 2.0
41 stars 15 forks source link

WsClient leaks in FilterWebsocketHandler.cs #39

Closed TechnikEmpire closed 6 years ago

TechnikEmpire commented 6 years ago

I'm assuming that WsClient inherits from IDisposable, since Coverity has flagged it as a dangling resource/leak. It needs to be explicitly disposed if this is the case. Perhaps we can just wrap the whole thing in a using statement, or we can do a try/finally.

TechnikEmpire commented 6 years ago

Fixed in 781b56f