search

TechnikEmpire / HttpFilteringEngine

Transparent filtering TLS proxy.
Mozilla Public License 2.0
60 stars 33 forks source link

Reading host header in TlsCapableHttpBridge::OnDownstreamHeaders silently fails #12

Closed TechnikEmpire closed 8 years ago

TechnikEmpire commented 8 years ago

Reading host header silently fails. The if(..) block which detects if the header range returned is empty fails, meaning no "Host" header is found in the lookup. Yet, no parser errors are thrown.

TechnikEmpire commented 8 years ago

Was partially due to me dropping bytesTransferred > 0 check in read completion handlers within TlsCapableHttpBridge.

Also was due to the fact that despite 443 being a standard port for HTTPS, a great many applications ignore the concept of "standard ports" and use proprietary comm over 443. In my testing application, for the Firewall check callback, I was simply returning "true", and thus diverting traffic from these applications that shamelessly disregard standards through the proxy, causing lots of various errors on failed reads, failures parsing TLS hello, etc. Those two things are resolved in next commit. However, still having issues with some websites over HTTPS where read is failing, but not over HTTP, so ticket is left open.