TechnikEmpire / HttpFilteringEngine

Transparent filtering TLS proxy.
Mozilla Public License 2.0
60 stars 33 forks source link

Success flag in BaseHttpTransaction::Parse() blocked by scope #31

Closed TechnikEmpire closed 8 years ago

TechnikEmpire commented 8 years ago

During finalization of payloads that are consumed until complete, inside the X class, within the method BaseHttpTransaction::Parse(), function local bool success is set like so:

`success = !finalizationFailed;

However, this set is done within the if (contentEncoding.first != contentEncoding.second), so for non-compressed payloads that are consumed until completion, BaseHttpTransaction::Parse() will always return failure. Fixed in next commit.