TechnikEmpire / HttpFilteringEngine

Transparent filtering TLS proxy.
Mozilla Public License 2.0
60 stars 33 forks source link

Adblock Plus request filtering is incorrect #48

Closed TechnikEmpire closed 8 years ago

TechnikEmpire commented 8 years ago

Adblock Plus filters are not functioning correctly. A large number of requests that are blocked by adblock plus, and in fact were blocked also by a previous unpublished version of this software, are not being blocked. I suspect this is due to the rewrite of the filtering rule parser and class structure.

TechnikEmpire commented 8 years ago

The culprit here is an incorrect understanding of the function of the pipe characters inside filters. Originally, I treated double pipes correctly (must be start of address or subdomain), but didn't handle trailing pipes, so I rewrote it to attempt to better understand the multiple functions of pipes and got it wrong.