TechnikEmpire / HttpFilteringEngine

Transparent filtering TLS proxy.
Mozilla Public License 2.0
60 stars 33 forks source link

Unmanaged->Manged delegates are wrong #69

Closed TechnikEmpire closed 8 years ago

TechnikEmpire commented 8 years ago

The delegates defined in the managed ref class Engine for providing C style callbacks to the unmanaged "side" are wrong. They need to be declared as unmanaged callbacks with the calling convention explicitly set to cdecl.

[UnmanagedFunctionPointer(CallingConvention::Cdecl)]

Without this modification, the calling convention defaults to stdcall and this explodes the universe.

PhyxionNL commented 8 years ago

this explodes the universe.

At least it's fixed now :+1:

TechnikEmpire commented 8 years ago

lol, yeah. Looks like everything is fixed now with this, except for the improvements that I've filed. Build instructions on the Wiki are being created (ported from a previous, unpublished generation of this project) and will be done in the next couple of days as a published binary release candidate of Stahp It is impending.

PhyxionNL commented 8 years ago

Nice work on everything :+1:

TechnikEmpire commented 8 years ago

@Phyxion thx