search

TechnikTobi / little_exif

A little library for reading and writing EXIF data in pure Rust.
Apache License 2.0
22 stars 5 forks source link

Implementing TIFF #17

Closed TechnikTobi closed 3 weeks ago

TechnikTobi commented 1 month ago 
          > This has to do with the MakerNotes IFD and, as I recently found out, is also the cause for issue #6. For now, with the fix in 0.5.0-beta2, this data will be handled as a single tag and not further processed. Please let me know if this solves the issue for you as well on other photos.

Yea ! The set of files I am currently testing with allows reading with new_from,_path. Many files also are handled without an error by new_from_vec. but in the set also is a file with the extension .tif. FileExtension::from_strcant handle this as there is no "tif" arm in the FileExtension enum yet. I did not yet test writing a file.....

_Originally posted by @mschnell1 in https://github.com/TechnikTobi/little_exif/issues/2#issuecomment-2395611381_

mschnell1 commented 1 month ago

looking forward to testing...

TechnikTobi commented 3 weeks ago

Available now in 0.6.0-beta6!

mschnell1 commented 3 weeks ago

WOW !

TechnikTobi commented 3 weeks ago

Seems like this worked on the first try?

mschnell1 commented 3 weeks ago

Just running a bunch of jpg file to check for glitches. I'll to a test with some TIFs ASAP.

mschnell1 commented 3 weeks ago

This file www.bitvibe.de/Upload/A0040275_5.tif does

thread 'main' panicked at C:\Users\Michael Schnell\.cargo\registry\src\index.crates.io-6f17d22bba15001f\little_exif-0.6.0-beta.6\src\ifd\mod.rs:705:29:
attempt to subtract with overflow
TechnikTobi commented 3 weeks ago

~With what code?~ Nevermind, can reproduce this now.

TechnikTobi commented 3 weeks ago

Fixed and released in 0.6.0-beta7! If beta 7 sorts out all TIFF problems on your side I think 0.6.0 is ready to be published as a full release. Let me know if anything else comes up on your side.

TechnikTobi commented 3 weeks ago

Now available in release 0.6.0!