search

TechnikTobi / little_exif

A little library for reading and writing EXIF data in pure Rust.
Apache License 2.0
22 stars 5 forks source link

hangs #27

Closed mschnell1 closed 3 weeks ago

mschnell1 commented 1 month ago

Just to let you know: EẀith this file the analyzing hangs seemingly forever.

-> www.bitvibe.de/Upload/_DSCZ784Z.JPG

TechnikTobi commented 1 month ago

Can't reproduce the issue using 

    let jpg_path = Path::new("./rsrc/_DSCZ784Z.JPG");

    // Read metadata from file
    for tag in Metadata::new_from_path(jpg_path).unwrap().data()
    {
        println!("{:?}", tag);
    }

With what task does this hang?

mschnell1 commented 1 month ago

Opening "new..." (AFAIR both from file as from Vec). on Windows 10, newest "released" rust version (might matter).

TechnikTobi commented 1 month ago

Well, I can't reproduce this issue so I can't tell what is going on.

TechnikTobi commented 3 weeks ago

Is this still the case with the newest beta version?

mschnell1 commented 3 weeks ago

No _DSCZ784Z.JPG now says: Error: failed to fill whole buffer (which I believe I did not see with beta.4 in the 1000 other testing files.)

mschnell1 commented 3 weeks ago

This now results in aborting the executable because clear_app13_segment()returns an error (exit code: 1) (which does not not with beta.4 in the 1000 other testing files.)

mschnell1 commented 3 weeks ago

Supposedly this is OK, as that file was written by a still buggy version of little_exif. My original file for that image works fine with beta.4.

TechnikTobi commented 3 weeks ago

Supposedly this is OK, as that file was written by a still buggy version of little_exif.

That would explain a lot, as the given file misses the expected JPG end of image segment 0xFFD9.

My original file for that image works fine with beta.4.

In that case I assume it also works with beta 5? If so we can close this issue.

mschnell1 commented 3 weeks ago

Yep I meant Beta.5 Lets close this.