search

Technion-Kishony-lab / data-to-paper

data-to-paper: Backward-traceable AI-driven scientific research
MIT License
433 stars 40 forks source link

Added Tuple for message contents #11

Open Ahmet-Kaplan opened 3 months ago

Ahmet-Kaplan commented 3 months ago

We may use tuple[T1, ..., Tn] to indicate a tuple type

TalIfargan commented 3 months ago

Hi @Ahmet-Kaplan,

Thank you for suggesting this modification for type hinting! In general, since we are willing to support python versions >= 3.9 we don't need to use typing module imported type annotations (see here for details https://mypy.readthedocs.io/en/stable/cheat_sheet_py3.html). So in this specific case I would replace all the imported collection hint types with the built-in supported type hints (Tuple[str, bool] --> tuple[str, bool], List[Message] --> list[Message], etc..).

See if you can fix this patch according to my suggestions and include changes to all the type annotations.

In addition, if you are willing to help us go through the repo and make sure type annotations are consistent throughout all the modules, it can be super helpful!