search

TechnionTDK / jbs-json23plet

A command-line tool for generating RDF triplets from Json input
1 stars 0 forks source link

PsukimTagsGenerator overrides previous output #16

Closed omishali closed 7 years ago

omishali commented 7 years ago

Hi, I executed basic generator an then executed PsukimTagsGenerator, and the latter overrides the output produced by the basic. It seems like the reason for that is that the method getId() is defined only for RegexGenerators but not for generators extending Generator (like Basic and PsukimTags).

I suggest to make the class Generator the base class of all generators and define the abstract class getId there. It is OK that also the basic generator will append the id "Basic" to the produced ttls like all other generators.

@TechnionTDK/team-json23plet

yontyon commented 7 years ago

done and pushed to GitHub.

On 26/01/17 10:03, Oren Mishali wrote:

Hi, I executed basic generator an then executed PsukimTagsGenerator, and the latter overrides the output produced by the basic. It seems like the reason for that is that the method getId() is defined only for RegexGenerators but not for generators extending Generator (like Basic and PsukimTags).

I suggest to make the class Generator the base class of all generators and define the abstract class getId there. It is OK that also the basic generator will append the id "Basic" to the produced ttls like all other generators.

@TechnionTDK/team-json23plet https://github.com/orgs/TechnionTDK/teams/team-json23plet

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/TechnionTDK/jbs-json23plet/issues/16, or mute the thread https://github.com/notifications/unsubscribe-auth/AWGEjcD5eXFA09tLncotzxjsXHYb1VTMks5rWFNCgaJpZM4LuYWK.

yontyon commented 7 years ago

add getID to generator

omishali commented 7 years ago

Great thanks, it works. p.s. It is a good practice to close the issue after the user has provided feedback about the fix (unless the developer has checked and is sure that it works as expected).