search

TechnionTDK / jbs-json23plet

A command-line tool for generating RDF triplets from Json input
1 stars 0 forks source link

Running with errorLevel=low still produces output #20

Closed omishali closed 7 years ago

omishali commented 7 years ago

I'm running the tool with errorLevel=low however I still see output in the console reporting on error. Previously there was no output in this case.

@TechnionTDK/team-json23plet

yontyon commented 7 years ago

Hi. Because the error of missing an URI property generates exception which cause the file not to be produced (and not like ordinary json validation errors) we preferred to show this error regardless the chosen error level. We can change it but then no info about unproduced files will appear.

On Mon, Mar 20, 2017, 15:52 Oren Mishali notifications@github.com wrote:

I'm running the tool with errorLevel=low however I still see output in the console reporting on error. Previously there was no output in this case.

@TechnionTDK/team-json23plet https://github.com/orgs/TechnionTDK/teams/team-json23plet

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/TechnionTDK/jbs-json23plet/issues/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AWGEjZ-7jmPcoe0v0dFUSFqTdd6mNFnoks5rnoSAgaJpZM4MidJO .

omishali commented 7 years ago

Then provide a shorter message in this case and suggest to increase error level.

בתאריך 20 במרץ 2017 4:03 אחה״צ,‏ "Yehonatan Buchnik" < notifications@github.com> כתב:

Hi. Because the error of missing an URI property generates exception which cause the file not to be produced (and not like ordinary json validation errors) we preferred to show this error regardless the chosen error level. We can change it but then no info about unproduced files will appear.

On Mon, Mar 20, 2017, 15:52 Oren Mishali notifications@github.com wrote:

I'm running the tool with errorLevel=low however I still see output in the console reporting on error. Previously there was no output in this case.

@TechnionTDK/team-json23plet https://github.com/orgs/TechnionTDK/teams/team-json23plet

— You are receiving this because you are on a team that was mentioned. Reply to this email directly, view it on GitHub https://github.com/TechnionTDK/jbs-json23plet/issues/20, or mute the thread https://github.com/notifications/unsubscribe-auth/AWGEjZ- 7jmPcoe0v0dFUSFqTdd6mNFnoks5rnoSAgaJpZM4MidJO .

— You are receiving this because you authored the thread. Reply to this email directly, view it on GitHub https://github.com/TechnionTDK/jbs-json23plet/issues/20#issuecomment-287768159, or mute the thread https://github.com/notifications/unsubscribe-auth/AC4uL6R37dquGCZspbiku6W_Dk0hNfPzks5rnoc8gaJpZM4MidJO .

yontyon commented 7 years ago

Done. @omishali