Fixes to tanachMefarshim

TechnionTDK / jbs-text

Input text files (Json format) for the Jewish Bookshelf Project.

1 stars 1 forks source link

Fixes to tanachMefarshim #10

Open omishali opened 7 years ago

omishali commented 7 years ago

This feedback is provided by looking at tanachMefarshim-4.json:

Change "Rashi" to "rashi" in the URI (small letter).
No need for "titles" array, it may be removed.
Note element jbr:tanach-baalhaturim-4-1-1, it has a wrong jbo:text value (or ramban).
The name of the mefaresh should be added to rdfs:label (e.g. רש"י במדבר א א).

shilonoa commented 7 years ago

fixed.

took out the Titles array
found the problem was a lack of space " " in the expresion : (מלבי"ם(, fixed it in all the raw files and put the fixed files in jbs-raw *added the mefaresh name to the rdfs:lable

omishali commented 7 years ago

More minor fixes:

For some reason the folder contains the file parser.mesilatYesharim.json.
No need here for packages jsons (remove from the C'tor the line createPackagesJson(); and these files will not be produced).
Add a new property for each object: JBO_NAME with a string value - the Hebrew name of the parshan, e.g., רש"י (take it from the existing array of names).

shilonoa commented 7 years ago

fixed

deleted the out of place jsons
added the JBO_NAME info after the LABLE in the structure

omishali commented 7 years ago

Hi Noa, I see many mismatches in the Tanach mefarshim files. By "mismatch" I mean cases where a persuh appears with a wrong URI.

For example, take a look at the file tanachMefarshim-1.json:

Search for a perush called "כלי יקר". For some reason, this perush always appears with a wrong URI.
I see many cases of mismatches for הרמב"ן
I can't see any URI for the perush "יונתן". It seems like its text is somehow included in the text of other Perushim.
It sees like you completely misses a perush called "שפתי חכמים".

These comments are only an example an I'm afraid that more mismatches exist. Please improve the testing and implementation of the parser.

shilonoa commented 7 years ago

the first problem is deu to Inconsistencies in the texts, i will add more tests. as to the last two problems, you asked for the interpreters from the list: ("רש\"י", "הרמב\"ן", "אור החיים", "אבן עזרא", "בעל הטורים" , "אונקלוס", "ספורנו", "כלי יקר", "דעת זקנים", "מצודת דוד", "מצודת ציון", "מלבי\"ם באור הענין", "מלבי\"ם באור המלות", "רלב\"ג", "מלבי\"ם") do you want me to add יונתן ושפתי חכמים?

omishali commented 7 years ago

yes add them too: yonatan, sifteychachamim.

בתאריך 5 באפר׳ 2017 9:21 אחה״צ,‏ "noa shilo" notifications@github.com כתב:

the first problem is deu to Inconsistencies in the texts, i will add more tests. as to the last two problems, you asked for the interpreters from the list: ("רש"י", "הרמב"ן", "אור החיים", "אבן עזרא", "בעל הטורים" , "אונקלוס", "ספורנו", "כלי יקר", "דעת זקנים", "מצודת דוד", "מצודת ציון", "מלבי"ם באור הענין", "מלבי"ם באור המלות", "רלב"ג", "מלבי"ם") do you want me to add יונתן ושפתי חכמים?

— You are receiving this because you modified the open/close state. Reply to this email directly, view it on GitHub https://github.com/TechnionTDK/jbs-text/issues/10#issuecomment-291950906, or mute the thread https://github.com/notifications/unsubscribe-auth/AC4uL05_8CPSg19FB5Qe-ejLdpyTDEO5ks5rs9uagaJpZM4McliH .