search

TechnionTDK / jbs-text

Input text files (Json format) for the Jewish Bookshelf Project.
1 stars 1 forks source link

Problems with generated jsons #3

Closed omishali closed 7 years ago

omishali commented 7 years ago

For example, consider the generated json below:

  1. There should a makaf after the name of the mefaresh, e.g., jbr:tanach-sforno-1-1-1.
  2. I mentioned to remove the "jbr" prefix at all.
  3. The elements for "sefer", "parasha" etc. are not correct: why are they surrounded with curly brackets?

Of course, these comments apply to all generated jsons.

p.s. for some reason, ramban's folder has no jsons...

{ "subjects": [{ "uri": "jbr:tanach-sforno1-1-1", "text": " ספורנו בראשית. בתחלת הזמן והוא רגע ראשון בלתי מתחלק שלא היה זמן קודם לו", "titles": [{ "title": "בראשית א א" }, { "title": "בראשית פרק א פסוק א" }] }, { "sefer": "tanach-1" }, { "parasha": "parasha-1" }, { "perek": "tanach-1-1" }, { "positionInPerek": 1 }, { "positionInParasha": 1 }, { "uri": "jbr:tanach-sforno1-1-2", ...

@TechnionTDK/team-text2json

omishali commented 7 years ago

I should have opened this issue in your repo and not here...

shilonoa commented 7 years ago

fixed