search

TechnionTDK / jbs-text2json

A command-line tool for turning raw text into json
0 stars 0 forks source link

Problem with some books names #27

Closed moshesab closed 7 years ago

moshesab commented 7 years ago

Hi, It seems like you didn't divide the two parts books (like שמואל which actually is שמואל א+שמואל ב) in the right way, meaning you didn't distinguish between them and gave them the same name (just שמואל in the example) as I saw in jbs-text. I found it problematic when I tried to tag some files with the web-tagger which uses your output. You should change the names of all the books that have this problem (שמואל, מלכים, דברי הימים etc)

In additin,please change the name of sefer דברי הימים to its full name "דברי הימים א"/ "דברי הימים ב" instead of just "דברי".

thanks.

@omishali @TechnionTDK/team-text2json @EylonSho

omishali commented 7 years ago

Moshe means that the "titles" attribute of those books is not correct.

2016-12-22 17:00 GMT+02:00 moshesab notifications@github.com:

Hi, It seems like you didn't divide the two parts books (like שמואל which actually is שמואל א+שמואל ב) in the right way, meaning you didn't distinguish between them and gave them the same name (just שמואל in the example) as I saw in jbs-text. I found it problematic when I tried to tag some files with the web-tagger which uses your output. You should change the names of all the books that have this problem (שמואל, מלכים, דברי הימים etc)

In additin,please change the name of sefer דברי הימים to its full name "דברי הימים א"/ "דברי הימים ב" instead of just "דברי".

thanks.

@omishali https://github.com/omishali @TechnionTDK/team-text2json https://github.com/orgs/TechnionTDK/teams/team-text2json @EylonSho https://github.com/EylonSho

— You are receiving this because you were mentioned. Reply to this email directly, view it on GitHub https://github.com/TechnionTDK/jbs-text2json/issues/27, or mute the thread https://github.com/notifications/unsubscribe-auth/AC4uL4-wSSehCX-myjQjuBJ9Fopo4-G7ks5rKpCDgaJpZM4LUDyP .