TechnionYP5777 / Bugquery

Bug query
9 stars 1 forks source link

Get Trace From User Input #13

Closed yosefraisman closed 7 years ago

yosefraisman commented 7 years ago

Expand use cases for stack trace obtaining. This issue is for getting the stack trace directly from the user. (parse input using class ExtractTrace from #12).

Possible Use Cases, Progress

~Fix bug with clipboard implementation. When copying content that originates in eclipse, using "Trace from Clipboard", clipboard access fails (!content.isDataFlavorSupported(DataFlavor.stringFlavor), happens - only in Linux).~ Moved over to a different issue.

yosefraisman commented 7 years ago

Progress: There's a working implementation of trace extraction from clipboard (needs cleanup, and there's a bug - getSystemClipboard() doesn't seem to work properly with content from within eclipse). Also, I know what to do about the input window (create a subclass of org.eclipse.jface.dialogs.InputDialog)

yossigil commented 7 years ago

Suggestion: write a test class to demonstrate what's working.

yosefraisman commented 7 years ago

Finished class ExtendedDialog and class FromInputDialog. Adding a test class isn't worth the time, I think, since it's impossible to cover user behavior when we offer interaction devices we can't emulate correctly (for example, the system clipboard toolkit access has - it seems - a bug in Linux, which we couldn't have detected with a test class). However, here's a video I made demonstrating all the input methods our plug-in supports so far (temporarily switching class SendTrace's default behavior to showing the output in a window, instead of looking it up in Google).

yossigil commented 7 years ago

You cannot run the video to make sure the class still works

yosefraisman commented 7 years ago

That's true, but it's good for demonstration (as you requested). I'm looking into testing the methods and interaction that can be covered.

yossigil commented 7 years ago

:+1:

yosefraisman commented 7 years ago

As discussed in our meeting, initial implementation of trace extraction from user input is complete. This week I'll deal with the two remaining problems with the current implementation (One is the clipboard bug in Linux, the second is the redrawing of the drop-down menu after clicking OK in the InputDialog). I'll add the new issues soon. Additionally, I'll add an issue for testing the methods from GetTrace, as requested in this thread.

yossigil commented 7 years ago

:+1: