Initial results page design

AdiOmari commented 7 years ago

You did some very nice advancements in styling the site. Did you consider using UI libraries like: bootstrap or semanticUI? I reviewed the jsp pages and could not find references to either.

yosefraisman commented 7 years ago

@AdiOmari, I did consider Bootstrap, but here's why I currently don't think we really need it:

Responsiveness isn't an issue for us as the site is meant primarily for desktops.
Having our own CSS and HTML makes it easier to define our classes and styling options (and makes maintenance easier since it's code I wrote and am familiar with).
It also makes the site more lightweight - no need to import javascript, for example, or stylesheets we don't use.

What do you think changing the implementation will improve?

AdiOmari commented 7 years ago

@yosefraisman the idea is that we can use their style for basic controls, and have our own custom design for the rest. It is not critical at this point, it is a suggestion that I think can make it easier for you.

yossigil commented 7 years ago

thought of reminding your of this

Amit-Oha commented 7 years ago

@yosefraisman @AdiOmari I think we passed on this?

AdiOmari commented 7 years ago

Right, closing it.

TechnionYP5777 / Bugquery

Initial results page design #32