TechnionYP5777 / Bugquery

Bug query
9 stars 1 forks source link

Update your spartanizer & handle the spartanizer tips #57

Closed ZivIzhar closed 7 years ago

ZivIzhar commented 7 years ago

Please update your spartanizer to the newest version and change your code to match the new changes in the spartanizer. Right now I'm seeing 25 tips from the spartanizer. Progress:

Amit-Oha commented 7 years ago

Done for my files. I must say, I think if one of us see this kind of mistakes he could just change it, it's only cosmetic refactoring, we must follow these conventions anyway and it's not going to break anything...

yonzarecki commented 7 years ago

It is going to break someone's code if they're currently working on it. If Ziv would push an updated version of your code it would just cause a merge conflict later, this way is cleaner.

Amit-Oha commented 7 years ago

You've got a point. In my opinion we shouldn't be so afraid of merges but past experience says otherwise 😄

ZivIzhar commented 7 years ago

Since it's a broad range issue - a change of our environment, I think the best way to do so without interrupting the continuous work of others is "everyone fix their own code", instead of making everyone solve conflict issues.

yonzarecki commented 7 years ago

@tonylekhtman, @yosefraisman, did you finish spartanizing ?

yosefraisman commented 7 years ago

:+1:

ZivIzhar commented 7 years ago

Please pull before making any further changes, I spartanized few files