"create_simulation_result.html" updates - Githubissues

TechnionYP5779 / SimuMole

Computer simulation method that displays the physical movements of atoms and molecules.

5 stars 0 forks source link

"create_simulation_result.html" updates #126

Closed IlanitSmul closed 5 years ago

IlanitSmul commented 5 years ago

Upload PDB & DCD:

Split the form into 2 seperate FileFields.
Render to create_simulation_result.html - only the animations section.
Until the code for creating the animation is ready - 6 basic animations are displayed, and a PyMOL window is open.
Add error handling: The PDB file does not match the DCD file. At the moment, the page can not be re-run because the PYMOL window remains open.

`create_simulation_result.html`:

Displays an error message if the simulation creation process (scr function) raise an exception.
Create zip: Change the file names in the zip.
Send mail: Add error handling (but, the function of sending an email, send_email, still does not work).

OrYasso commented 5 years ago

This pull request introduces 4 alerts and fixes 3 when merging 0df5a9b2194def2924842c0375d972cd191a4fdc into 1ed42158138a1da139c8f8e68369aeea637d6142 - view on LGTM.com

new alerts:

4 for Except block handles 'BaseException'

fixed alerts:

1 for Unused local variable
1 for Unused import
1 for Variable defined multiple times

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com