complete #104 + #132 - Githubissues

TechnionYP5779 / SimuMole

Computer simulation method that displays the physical movements of atoms and molecules.

5 stars 0 forks source link

complete #104 + #132 #134

Closed IlanitSmul closed 5 years ago

IlanitSmul commented 5 years ago

104: Resolve problems with running the simulation checks
- The "clean" function runs only twice: when you press the "next" buttun (or "previous" button) of that step, and when you press "submit" (then all the "clean" functions run again, one after the other).
132: Move production steps earlier

OrYasso commented 5 years ago

This pull request introduces 1 alert and fixes 4 when merging 0d03f6d268b2ea836a5f700dfe4d2950565516da into fe19f51fde7a66b359f40876357684bee7eb005f - view on LGTM.com

new alerts:

1 for Unused import

fixed alerts:

4 for Except block handles 'BaseException'

This project has automated code review enabled, but doesn't use the LGTM GitHub App. Migrate over by installing the app. Read about the benefits of migrating to GitHub Apps in the blog.

Comment posted by LGTM.com

TechnionYP5779 / SimuMole

complete #104 + #132 #134

104: Resolve problems with running the simulation checks

132: Move production steps earlier