TechnionYP5779 / team1

Git repo of team 1 of the yearly project technion CS
6 stars 3 forks source link

Issue/190/design sign in form #210

Closed yoavz1997 closed 5 years ago

yoavz1997 commented 5 years ago

All the user-end parts in this form are done. After the whole UI is finished the back-end support will be added

yoavz1997 commented 5 years ago

The Travis check failed due to code in the SimpleWebParser tests. Checking now

yoavz1997 commented 5 years ago

I'm not sure, why one Travis check pass, and another does not... @ofiralexi @ShaiZeevi @saifun @matanpugach @YarinSh @Itamaror any ideas?

ofiralexi commented 5 years ago

@yoavz1997 I found this discussion in stackoverflow regarding your issue, want to check if it works ? https://stackoverflow.com/questions/41524861/travis-failed-push-but-passed-pr

Code looks fine, lets merge to test the theory

ofiralexi commented 5 years ago

@yoavz1997 the merge passed, keeping it on develop. image