search

TechnionYP5779 / team6

7 stars 0 forks source link

Change to spartanizer rule, OurServer, added docs #190

Closed HadadIdan closed 5 years ago

HadadIdan commented 5 years ago

Changed a line in OurServer for it to work as expected. Removed a spartanizer rule (since you can't surpress tips) "ClassIntanceCreationBoxedValueTypes" as in some cases (like the one explained in #187) it changes the functionality of line. Added many more Docs, but not every Doc, since the old classes of Spartanizer didn't follow Java Doc rules perfectly...

HadadIdan commented 5 years ago

This pull request fixes 1 alert when merging 60925f8fb7eff05f46cea4065547447623bab825 into a3a188f428a603757befb272476799306e427ad2 - view on LGTM.com

fixed alerts:

Comment posted by LGTM.com

EyalFaygen commented 5 years ago

why do we need all the javadoc output if we can generate it whenever we need?

HadadIdan commented 5 years ago

@EyalFaygen A) To prevent the need to generate them B) Current settings i used to generate enable the generation of some docs that can't be generated without those exact settings. @EyalFaygen

EyalFaygen commented 5 years ago

ok. reviewed everything that is not a javadoc auto-generated and it looks good

HadadIdan commented 5 years ago

This pull request fixes 1 alert when merging ad394ee60056b64e07203b0ace71b3791cd2580c into 6a5f8a33707e0957bbb3089571f1b156e9be983c - view on LGTM.com

fixed alerts:

Comment posted by LGTM.com