search

TechnitiumSoftware / DnsServer

Technitium DNS Server
https://technitium.com/dns/
GNU General Public License v3.0
4.25k stars 418 forks source link

"Last year" graph is mislabeling the months #1023

Closed cob-web-corner closed 1 day ago

cob-web-corner commented 2 weeks ago

Small thing I found it's not major but figured I would report it. The metrics graph on the dashboard does not show the proper months for the metrics and it's missing the most recent month's data when selecting "Last Year" tab.

It looks like all of the months are 1 off

Picture from one of my instances: image

cob-web-corner commented 2 weeks ago

forgot to mention Version 12.2.1

ShreyasZare commented 2 weeks ago

Thanks for the feedback. This is due to time zone issue in the js code which is generating the custom API call. If you set your system's time zone to UTC then both the numbers would match.

Will get this fixed to match the values as expected.

ShreyasZare commented 1 week ago

Technitium DNS Server v13 is now available that fixes this issue. Do update and let me know your feedback.

cob-web-corner commented 1 week ago

Hi @ShreyasZare it looks like the issue is still persisting. Thanks for checking in on this

image

ShreyasZare commented 6 days ago

Thanks for the feedback. The query count should match now but I am not able to reproduce the label issue for "Last Year" stats. I am getting the most recent month in all of my deployments:

image

Please let me know what timezone you have configured on your client and will try to have the same to see if this can be reproduced.

cob-web-corner commented 2 days ago

This appear to be happening in UTC -4, UTC -7, and UTC -10. I dont have any clients conntected to this test server outside of those timezones so it could be happening in others as well. The server is currently configured to UTC-4 America/New_York

ShreyasZare commented 2 days ago

This appear to be happening in UTC -4, UTC -7, and UTC -10. I dont have any clients conntected to this test server outside of those timezones so it could be happening in others as well. The server is currently configured to UTC-4 America/New_York

I was able to reproduce it. Will get it updated in the next update.

ShreyasZare commented 1 day ago

Technitium DNS Server v13.0.2 is now available that fixes this issue. Do update and let me know your feedback. Note to use Ctrl+F5 to reload admin panel after upgrade so that browser does not use cached pages.

cob-web-corner commented 1 day ago

LGTM

Great work, thank you!

ShreyasZare commented 18 hours ago

Thanks for the feedback!