TechnitiumSoftware / DnsServer

Technitium DNS Server
https://technitium.com/dns/
GNU General Public License v3.0
4.27k stars 418 forks source link

"Check for update was done" message contains "New Update Available" even when on latest version #624

Closed ztheory closed 1 year ago

ztheory commented 1 year ago

When starting the latest version, I see that the update checker still prints messages encouraging downloading the latest version.

[2023-05-08 16:07:43 UTC] DNS Server (v11.1.1.0) was started successfully.
[2023-05-08 16:07:52 UTC] DNS Server auth config file was saved: C:\Program Files (x86)\Technitium\DNS Server\config\auth.config
[2023-05-08 16:08:13 UTC] [127.0.0.1:50112] Check for update was done {updateAvailable: False; updateVersion: 11.1.1; updateTitle: New Update (v11.1.1) Available!; updateMessage: Download and install the setup to update the DNS server to the latest version. Read the change logs before installing this update to know if there are any breaking changes.; downloadLink: https://download.technitium.com/dns/DnsServerSetup.zip; changeLogLink: https://github.com/TechnitiumSoftware/DnsServer/blob/master/CHANGELOG.md;}
[2023-05-08 16:08:27 UTC] [127.0.0.1:50112] Check for update was done {updateAvailable: False; updateVersion: 11.1.1; updateTitle: New Update (v11.1.1) Available!; updateMessage: Download and install the setup to update the DNS server to the latest version. Read the change logs before installing this update to know if there are any breaking changes.; downloadLink: https://download.technitium.com/dns/DnsServerSetup.zip; changeLogLink: https://github.com/TechnitiumSoftware/DnsServer/blob/master/CHANGELOG.md;}
[2023-05-08 16:21:34 UTC] [127.0.0.1:50166] Check for update was done {updateAvailable: False; updateVersion: 11.1.1; updateTitle: New Update (v11.1.1) Available!; updateMessage: Download and install the setup to update the DNS server to the latest version. Read the change logs before installing this update to know if there are any breaking changes.; downloadLink: https://download.technitium.com/dns/DnsServerSetup.zip; changeLogLink: https://github.com/TechnitiumSoftware/DnsServer/blob/master/CHANGELOG.md;}
[2023-05-08 16:28:08 UTC] [127.0.0.1:50183] Check for update was done {updateAvailable: False; updateVersion: 11.1.1; updateTitle: New Update (v11.1.1) Available!; updateMessage: Download and install the setup to update the DNS server to the latest version. Read the change logs before installing this update to know if there are any breaking changes.; downloadLink: https://download.technitium.com/dns/DnsServerSetup.zip; changeLogLink: https://github.com/TechnitiumSoftware/DnsServer/blob/master/CHANGELOG.md;}
[2023-05-08 16:29:27 UTC] [127.0.0.1:50187] Check for update was done {updateAvailable: False; updateVersion: 11.1.1; updateTitle: New Update (v11.1.1) Available!; updateMessage: Download and install the setup to update the DNS server to the latest version. Read the change logs before installing this update to know if there are any breaking changes.; downloadLink: https://download.technitium.com/dns/DnsServerSetup.zip; changeLogLink: https://github.com/TechnitiumSoftware/DnsServer/blob/master/CHANGELOG.md;}
[2023-05-08 16:29:38 UTC] [127.0.0.1:50186] Check for update was done {updateAvailable: False; updateVersion: 11.1.1; updateTitle: New Update (v11.1.1) Available!; updateMessage: Download and install the setup to update the DNS server to the latest version. Read the change logs before installing this update to know if there are any breaking changes.; downloadLink: https://download.technitium.com/dns/DnsServerSetup.zip; changeLogLink: https://github.com/TechnitiumSoftware/DnsServer/blob/master/CHANGELOG.md;}
[2023-05-08 16:36:32 UTC] [127.0.0.1:50224] Check for update was done {updateAvailable: False; updateVersion: 11.1.1; updateTitle: New Update (v11.1.1) Available!; updateMessage: Download and install the setup to update the DNS server to the latest version. Read the change logs before installing this update to know if there are any breaking changes.; downloadLink: https://download.technitium.com/dns/DnsServerSetup.zip; changeLogLink: https://github.com/TechnitiumSoftware/DnsServer/blob/master/CHANGELOG.md;}
[2023-05-08 17:15:34 UTC] [127.0.0.1:50224] Check for update was done {updateAvailable: False; updateVersion: 11.1.1; updateTitle: New Update (v11.1.1) Available!; updateMessage: Download and install the setup to update the DNS server to the latest version. Read the change logs before installing this update to know if there are any breaking changes.; downloadLink: https://download.technitium.com/dns/DnsServerSetup.zip; changeLogLink: https://github.com/TechnitiumSoftware/DnsServer/blob/master/CHANGELOG.md;}
[2023-05-08 17:15:43 UTC] [127.0.0.1:50301] Check for update was done {updateAvailable: False; updateVersion: 11.1.1; updateTitle: New Update (v11.1.1) Available!; updateMessage: Download and install the setup to update the DNS server to the latest version. Read the change logs before installing this update to know if there are any breaking changes.; downloadLink: https://download.technitium.com/dns/DnsServerSetup.zip; changeLogLink: https://github.com/TechnitiumSoftware/DnsServer/blob/master/CHANGELOG.md;}
[2023-05-08 17:16:07 UTC] [127.0.0.1:50224] Check for update was done {updateAvailable: False; updateVersion: 11.1.1; updateTitle: New Update (v11.1.1) Available!; updateMessage: Download and install the setup to update the DNS server to the latest version. Read the change logs before installing this update to know if there are any breaking changes.; downloadLink: https://download.technitium.com/dns/DnsServerSetup.zip; changeLogLink: https://github.com/TechnitiumSoftware/DnsServer/blob/master/CHANGELOG.md;}
[2023-05-08 17:18:57 UTC] [127.0.0.1:50224] Check for update was done {updateAvailable: False; updateVersion: 11.1.1; updateTitle: New Update (v11.1.1) Available!; updateMessage: Download and install the setup to update the DNS server to the latest version. Read the change logs before installing this update to know if there are any breaking changes.; downloadLink: https://download.technitium.com/dns/DnsServerSetup.zip; changeLogLink: https://github.com/TechnitiumSoftware/DnsServer/blob/master/CHANGELOG.md;}
[2023-05-08 17:19:23 UTC] [127.0.0.1:50314] Check for update was done {updateAvailable: False; updateVersion: 11.1.1; updateTitle: New Update (v11.1.1) Available!; updateMessage: Download and install the setup to update the DNS server to the latest version. Read the change logs before installing this update to know if there are any breaking changes.; downloadLink: https://download.technitium.com/dns/DnsServerSetup.zip; changeLogLink: https://github.com/TechnitiumSoftware/DnsServer/blob/master/CHANGELOG.md;}

Perhaps something like this simple message is expected if no update available:

[2023-05-08 16:21:34 UTC] [127.0.0.1:50166] Check for update was done - No available update

Also, the updater checker runs quite often, at least initially after service start. Perhaps consider checking once during service start and then a few times per day afterwards to reduce the noisiness of the logs and the amount of web calls on your side.

ShreyasZare commented 1 year ago

Thanks for the post. The log entry the output that was received from the update server verbatim to help with debugging any issues. It adds updateAvailable boolean value to indicate what it detected which in this case is False meaning that no update is available.

The update check is done only when you login to the DNS server web panel. It is actually triggered by the js on the client side to check if update is available. If there is an update available then you will see a notification in the GUI. There is no timer to check for update.

The frequent log entries you see are thus your attempts to login that frequently on the web panel or that you used F5 to refresh the entire web app which will lead the js to call the update check API.

Since the web app is a single page app, I would recommend that you click on the tabs on the GUI to refresh content in it, for example, clicking on the Dashboard tab will refresh the dashboard data. Some tabs do not refresh this way to preserve its view state but you will find a refresh option in there to refresh the data.