TechnitiumSoftware / DnsServer

Technitium DNS Server
https://technitium.com/dns/
GNU General Public License v3.0
4.27k stars 418 forks source link

Restore of settings fails #677

Closed jho1670 closed 1 year ago

jho1670 commented 1 year ago
  1. Do backup of settings on 9.x
  2. Upgrade to 11.3
  3. Restore of settings fails "Error! Multipart body length limit 134217728 exceeded."

a) Backup of server ( no logs ) was 373MB. This seems excessively large. I left default settings, and did not include logging. b) Backup function should not generate backup archive that does not restore.

ShreyasZare commented 1 year ago

Thanks for the feedback. The DNS server does not impose any upload size limits. It could be that you have a reverse proxy configured to access the DNS server web panel which has default config for upload size.

EHRETic commented 1 year ago

Hi there,

I got the same issue today by trying to migrate one of my instances from a VM to a docker instance (both 11.3) I also thought about reverse proxy in the first place so I disabled it (so no RP to download nor to upload backup file) but this didn't change the outcome. I also tried several backup/restore combinations (no logs, no stats), the same.

Some stats about backup files:

Yesterday I moved another instance successfully with the same method but backup file was a lot smaller. (Here: https://github.com/TechnitiumSoftware/DnsServer/discussions/691)

Could there be any size limit somewhere in a component (not the DNS server itself)? Thx in advanceπŸ˜‰

jho1670 commented 1 year ago
  1. I don't have a reverse proxy in front of the DNS server web panel. I am accessing port :5380 directly.
  2. As a workaround, I opened the ZIP file and deleted a pile of unnecessary logs, and the restore worked successfully.
EHRETic commented 1 year ago
  1. As a workaround, I opened the ZIP file and deleted a pile of unnecessary logs, and the restore worked successfully.

I'll try that later on, I'll let you know. Thx πŸ˜‰

ShreyasZare commented 1 year ago

Thank you guys for the feedback. I found the issue. The web server itself did not have any upload limit issue but the upload Form data parser had a default limit of 128mb.

Fix for this will be available in the upcoming release that is scheduled for this weekend.

EHRETic commented 1 year ago

Well, was a bit sketchy, but I created 2 backups files, one without stats and logs and one with. πŸ˜‰πŸ‘Œ

I extracted the files and copied them with WinSCP directly in Docker volume folder, that worked fine.

EHRETic commented 1 year ago

Fix for this will be available in the upcoming release that is scheduled for this weekend.

Marvelous, glad we could help you find another (tiny) bug! πŸ‘ŒπŸ˜‰

ShreyasZare commented 1 year ago

Well, was a bit sketchy, but I created 2 backups files, one without stats and logs and one with. πŸ˜‰πŸ‘Œ

I extracted the files and copied them with WinSCP directly in Docker volume folder, that worked fine.

This is fine. The restore process essentially does the same thing. Only difference is that you will need to stop the DNS server when manually restoring the files while with the Restore option does it without restarting.

ShreyasZare commented 1 year ago

Technitium DNS Server v11.4 is now available that fixes this issue by setting the upload limit to 2GB. Do update and let me know your feedback.

EHRETic commented 1 year ago

Technitium DNS Server v11.4 is now available that fixes this issue by setting the upload limit to 2GB. Do update and let me know your feedback.

Worked for me on a test instance (don't have instances to migrate anymore... 😊) Version was 11.4.1 BTW

ShreyasZare commented 1 year ago

Thanks for confirming.