TechnoPunter / trade-exec-engine

Takes care of order execution, management & reporting
GNU General Public License v3.0
0 stars 2 forks source link

More Logging for WebSocket Retry #3

Closed alansaviolobo closed 9 months ago

alansaviolobo commented 9 months ago

Need more logging for WebSocket Errors to take it up with shoonya. day and date | error message | account | count of retry attempts

pra1had commented 9 months ago

[2023-11-15 09:21:46,540] | [ERROR] predict.service.socketSLmonitor | [Thread-1 (ws_run_forever)] | Error message Connection to remote host was lost. [2023-11-15 09:21:50,511] | [ERROR] websocket | [Thread-1 (ws_run_forever)] | Connection to remote host was lost. - goodbye [2023-11-15 09:21:50,612] | [WARNING] NorenRestApiPy.NorenApi | [Thread-1 (ws_run_forever)] | websocket run forever ended in exception, socket is already opened [2023-11-15 09:21:50,712] | [WARNING] NorenRestApiPy.NorenApi | [Thread-1 (ws_run_forever)] | websocket run forever ended in exception, socket is already opened

This is what we have in the error handler:

def event_handler_error(message):
    logger.error(f"Error message {message}")
    send_email(body=f"Error in websocket {message}", subject="Websocket Error!")
alansaviolobo commented 9 months ago

Even shunya sadasya that we retry a script. So I suppose the retry is in order

On Wed, Nov 15, 2023, 6:54 PM Pralhad Kamath @.***> wrote:

[2023-11-15 09:21:46,540] | [ERROR] predict.service.socketSLmonitor | [Thread-1 (ws_run_forever)] | Error message Connection to remote host was lost. [2023-11-15 09:21:50,511] | [ERROR] websocket | [Thread-1 (ws_run_forever)] | Connection to remote host was lost. - goodbye [2023-11-15 09:21:50,612] | [WARNING] NorenRestApiPy.NorenApi | [Thread-1 (ws_run_forever)] | websocket run forever ended in exception, socket is already opened [2023-11-15 09:21:50,712] | [WARNING] NorenRestApiPy.NorenApi | [Thread-1 (ws_run_forever)] | websocket run forever ended in exception, socket is already opened

This is what we have in the error handler:

def event_handler_error(message): logger.error(f"Error message {message}") send_email(body=f"Error in websocket {message}", subject="Websocket Error!")

— Reply to this email directly, view it on GitHub https://github.com/TechnoPunter/trade-exec-engine/issues/3#issuecomment-1812533184, or unsubscribe https://github.com/notifications/unsubscribe-auth/AAJFQ4OSTT3OQXPOEWOK3ELYES7CPAVCNFSM6AAAAAA7MFUTA2VHI2DSMVQWIX3LMV43OSLTON2WKQ3PNVWWK3TUHMYTQMJSGUZTGMJYGQ . You are receiving this because you authored the thread.Message ID: @.***>

pra1had commented 9 months ago

Added retry I will raise new defect if the current fix doesn't solve the problem.