Drawer for better playlist UI on mobile

Technoculture / echoes

For collaboration between R&D teams and AI agents

https://www.echoes.team/

MIT License

6 stars 1 forks source link

Drawer for better playlist UI on mobile #70

Closed Rohittomar01 closed 5 months ago

Rohittomar01 commented 5 months ago

task was use drawer in place of dialog box.

install drawer of shadcn.
applied drawer for mobile view.
I did it in audioplayer file.

vercel[bot] commented 5 months ago

The latest updates on your projects. Learn more about Vercel for Git ↗︎

Name	Status	Preview	Comments	Updated (UTC)
echoes	✅ Ready (Inspect)	Visit Preview	💬 Add feedback	Jan 11, 2024 5:06pm
echoes-pag8	❌ Failed (Inspect)			Jan 11, 2024 5:06pm

sweep-ai[bot] commented 5 months ago

Apply Sweep Rules to your PR?

[ ] Apply: All new business logic should have corresponding unit tests.
[ ] Apply: Refactor large functions to be more modular.
[ ] Apply: Add docstrings to all functions and file headers.

sutyum commented 5 months ago

Your checks are failing so you need to fix them to move forward. The preview is also failing - you need to fix.

You should not use non-descriptive names for commits, branches and pull requests.

For example prefer branch name such as "feat-drawer" instead of "rohit".
PR title should describe what the PR is about - example - "Improving playlist UI on mobile" instead of "Rohit".
Commit names should be descriptive but short. . as a commit message is not acceptable. Avoid "I" in the commit messages as well

I have also shared a minor review but I need to see the preview before checking the main changes @Rohittomar01

sutyum commented 5 months ago

why have you closed this branch? @Rohittomar01

sutyum commented 5 months ago

It seems you have added this project on your own vercel account which is causing these errors. delete your personal vercel deployment of echoes in order to move forward

sutyum commented 5 months ago

will close #66