TechnologyEnhancedLearning / DLSV2

Progressive refactor of the Digital Learning Solutions web apps to .Net Core tech stack
MIT License
5 stars 1 forks source link

TD-4884 Prevent supervisors from viewing/reviewing self assessments in a category that doesn't match their own #2920

Closed sherif-olaboye closed 3 weeks ago

sherif-olaboye commented 4 weeks ago

JIRA link

https://hee-tis.atlassian.net/browse/TD-4884

Description

I added adminCategoryId to the method parameter and where the condition of GetSelfAssessmentsForSupervisorDelegateId method to limit supervisor view to the SelfAssessments that do not belong to the supervisor category I added adminCategoryId to the method parameter and where the condition of GetSelfAssessmentByCandidateAssessmentId method to ensure that the supervisor can not view or review SelfAssessments that do not belong to the supervisor category

Screenshots

When the admin categoryId is null image When the admin categoryId is 34 image image


Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have: