TechnologyEnhancedLearning / DLSV2

Progressive refactor of the Digital Learning Solutions web apps to .Net Core tech stack
MIT License
5 stars 1 forks source link

TD-4880 Prevent administrators from viewing Activity Delegates for self assessments in a category that doesn't match their own #2922

Closed ABSinhaa closed 3 weeks ago

ABSinhaa commented 4 weeks ago

JIRA link

TD-4880

Description

Added a check for the categoryId of the admin users while fetching the self assessments, making sure we only pull the self assessments that matches the categoryId on the admin account of the user, also added an Unauthorized check when anyone tries to manipulate the self assessment delegates using the query string URL being opened. If there's a categoryId on the admin account of the user, then show self assessments that are specific to the categoryId, if there's no categoryId on the admin account of the user, continue showing all the self assessments.

Screenshots

image image image

Developer checks

(Leave tasks unticked if they haven't been appropriate for your ticket.)

I have: