TechnologyRediscovery / codenforce

municipal code enforcement database application
GNU General Public License v3.0
2 stars 3 forks source link

CorpSearch API parsing bug #218

Open snapperVibes opened 2 years ago

snapperVibes commented 2 years ago

Corpsearch does not properly parse the "Street" field, instead labeling part of the city name as a street modifer. The correct town in the below example should be parsed as EAST MCKEESPORT. Drew suggested that perhaps you can use the newline \n as a parsing delimiter which would help not tack the EAST onto street but onto city. We're not sure if this is the third party library or your own parsing.

Example:

curl -X GET "https://corpsearch-api.pittsburghhousing.org/browser/owner-info/0546M00229000000" -H  "accept: application/json" -H  "Authorization:  API_KEY_GOES_HERE"
{
  "results": {
    "mailing": {
      "original": "569 HELENA AVE \nEAST MC KEESPORT , PA 15035-1042",
      "cleaned": "569 HELENA AVE EAST MC KEESPORT, PA 15035-1042",
      "parsed": {
        "number": "569",
        "street": "HELENA",
        "type": "Ave",
        "suffix": "E",
        "city": "MC KEESPORT",
        "state": "PA",
        "zip": "15035",
        "plus4": "1042"
      }
    },
    "mortgage": {
      "original": "USOW MARGARET A\n569 HELENA ST\nEAST MC KEESPORT PA\n15035\n",
      "cleaned": "569 HELENA ST EAST MC KEESPORT PA 15035",
      "parsed": {
        "number": "569",
        "street": "HELENA",
        "type": "St",
        "suffix": "E",
        "city": "MC KEESPORT",
        "state": "PA",
        "zip": "15035"
      }
    }
  }
}

Attention Field

Corpsearch does not properly parse the "Attention" field, instead labeling it as a street. Example

curl -X GET "https://corpsearch-api.pittsburghhousing.org/browser/owner-info/0547J00131000000" -H  "accept: application/json" -H  "Authorization:  API_KEY_GOES_HERE"
{
  "results": {
    "mortage": {
      "original": "CORELOGIC COMMERICAL\nATTENTION: BILLS RECIEVED PO BOX 9201\nCOPPELL TX\n75019\n",
      "cleaned": "ATTENTION: BILLS RECIEVED PO BOX 9201 COPPELL TX 75019",
      "parsed": {
        "street": "ATTENTION"
      }
    }
  }
}