Sprite fixes - Githubissues

Techokami / SonicWorldsNext

Official development repository for the successor to Sonic Worlds Delta

MIT License

133 stars 28 forks source link

Sprite fixes #114

Closed BlueStaggo closed 9 months ago

BlueStaggo commented 10 months ago

Moved player sprites up by one pixel and adjusted the HUD to be more accurate to the Genesis games.

Techokami commented 10 months ago

While I do appreciate the HUD fixes, are you sure about the player sprite adjustments? I could swear the player did, in fact, stand one pixel into the ground...

DimensionWarped commented 10 months ago

I feel like we're going to keep revisiting this subject over and over. Let's deal with this now...

Sonic 1 - in the ground

Sonic 1 - above the ground!

Sonic 1 tie breaker - above the ground

Sonic 2 - above the ground

Sonic 3 - above the ground

Above the ground wins.

DimensionWarped commented 10 months ago

There are some changes that don't immediately appear relevant to the stated intention of the patch -- explain and/or revert them:

Acceptance Criteria

Make sure the shift to the player's graphical mask doesn't look incorrect on any specific gimmick or terrain piece
Make sure the change doesn't result in any mechanical issues
Verify the UI looks right at all single minute digit times and double minute digit times.
Verify that the UI looks right at single digit , two digit, and three digit ring counts.

BlueStaggo commented 10 months ago

I have a feeling that my hacky solution of transforming the player sprite by -1 Y probably messes with things and needs checking up (I do not have the time and effort for this right now). Maybe it needs to be done using the offset instead?

BlueStaggo commented 10 months ago

I updated the hanging offsets but I think that may have messed up grabbing onto Tails, idk.

DimensionWarped commented 10 months ago

The Tails grabbing stuff is already so hacky that I'm not especially upset if it's a pixel off right now. It doesn't seem to have broken anything as far as I can tell testing at 60fps and 120fps, so I'm ok with this going in.

EDIT: Before I commit to that though, I wonder if the appropriate fix for this wouldn't have been adjusting the sprite sheet rather than adjusting the sprite objects... I'll let @Renhoex call the final shot.

DimensionWarped commented 10 months ago

Went ahead and tested Amy and Knuckles on all gimmicks and they seem fine too.

BlueStaggo commented 9 months ago

Ugh, merge conflicts. I'm going to close this pull request but this should be easy (albeit a bit tedious) to recreate without the hacky method that I used.