search

Techokami / SonicWorldsNext

Official development repository for the successor to Sonic Worlds Delta
MIT License
139 stars 29 forks source link

Reset player rotation when colliding with a air launching spring #204

Closed Renhoex closed 3 weeks ago

NeonSRB2 commented 3 weeks ago

Yay, ren fixed that one spring that i hate

dont mind if i take that right now

Renhoex commented 3 weeks ago

yeah, just waiting for the change to be reviewed before merging it

NeonSRB2 commented 3 weeks ago

Just tried porting the changes to cc and... it doesn't work, still does angle shenanigans when sprung.

Can you confirm that the issue is actually fixed here somehow?

NeonSRB2 commented 3 weeks ago

Reproducible example: put a diagonal spring on a large, 45 degree slope. The spring should not spring you either directly sideways or upward, but it does anyway.

Renhoex commented 3 weeks ago

should be clear when i said review I meant from someone else on the team, wasn't aware this was an issue with diagonal springs too, it's late here so I'll try to get to this soon

NeonSRB2 commented 3 weeks ago

For me, this worked when I used this line before setting body.movement: body.angle = body.gravityAngle

Caverns4 commented 3 weeks ago

The issue with the spring seems to be fixed, I see no problems. Neon, I'll fix the issue you reported momentarily.