Techokami / SonicWorldsNext

Official development repository for the successor to Sonic Worlds Delta
MIT License
139 stars 29 forks source link

When i change the super music it doesnt stop playing #92

Closed Raptorq1 closed 1 year ago

Raptorq1 commented 1 year ago

All I did to make this issue happen is change the super track

here's the original code

Global.currentTheme = 0 Global.effectTheme.stream = Global.themes[Global.currentTheme] Global.effectTheme.play() To this, this is a example Global.currentTheme = 5 Global.effectTheme.stream = Global.themes[Global.currentTheme] Global.effectTheme.play() And when I let super sonic run out the music wouldn't stop

DimensionWarped commented 1 year ago

Issue doesn't impact the codebase without actual code changes. If this had simply been changing the value of the invincibility music in the Global.themes array, I would have been inclined to say we had an issue, but after validating that I can change that music myself without issue I'm no longer of that opinion.

Reminder that we only support the engine as it comes, not as you may have made it.

NeonSRB2 commented 5 months ago

All I did to make this issue happen is change the super track

here's the original code

Here's the line that causes the issue in Player.gd: if Global.currentTheme == 0 and Global.effectTheme.is_playing():

You changed currentTheme in your code example to 5, so you should make it try to stop if that's playing as well. Here's an example: if (Global.currentTheme == 0 or Global.currentTheme == 5) and Global.effectTheme.is_playing():

These problems should be in Discussions, as it's not to do with the engine, as the engine only has 1 super theme, and if a different one played when you power down you'd have the regular level theme whilst having speed shoes/invincibility.