TechpriestEnginseer / Community-Patch-Events-Development

If you are interested in joining or have any issues. Leave me a PM or post in the issue tab.
GNU General Public License v3.0
2 stars 2 forks source link

Japan UE: Choice 4 #37

Closed 8h42 closed 8 years ago

8h42 commented 8 years ago

I can't see the turn duration of WLTKD. japan ue

I assume something's wrong with the EventDuration.

cf. (7) Community Events (v 2)\XML\Hokath\CivilizationEvents.xml

<Type>EVENT_JAPAN_UE_CHOICE_4</Type>
<Help>TXT_KEY_EVENT_JAPAN_UE_HELP_CHOICE_4</Help>
<Description>TXT_KEY_EVENT_JAPAN_UE_DESCRIPTION_CHOICE_4</Description>
<IsOneShot>true</IsOneShot>
<EventBuildingClassGlobal>BUILDINGCLASS_JAPAN_UE_DUMMY_2</EventBuildingClassGlobal>
<RequiredAnywhereBuildingClass>BUILDINGCLASS_OPERA_HOUSE</RequiredAnywhereBuildingClass>
<EventDuration>-1</EventDuration>
TechpriestEnginseer commented 8 years ago

No, that's intentional. Event Duration with Negative are also known as forever, but it doesn't have a Column. I'll change thanks!

Hokath commented 8 years ago

Problem with writing in "5 turns" is that the tooltip doesn't scale with gamespeed, so usually I would set EventDuration to the same time as WLTKDTurns and grab that: since the Duration on its own is documented just as a cooldown control, and it is the additional Expires tag that causes effects to cease. However I am a little uneasy about the UnhappinesNeedsXYZ, because it doesn't have documentation under Expires, but I feel it should be allowed to turn off somehow. See what I'm getting at?

TechpriestEnginseer commented 8 years ago

What I would usually do about that would include Lua... but seeing how it's just a simple event choice.. do we really want a reason to?

Hokath commented 8 years ago

Naa not worth.

Do you think the UnhappinessNeedMod would stay after the event ended?

TechpriestEnginseer commented 8 years ago

Nope, if it has an expire tag that means it'll take out the UnhappinesNeedMod after its duration.

Hokath commented 8 years ago

ok I'll do an expires = false tag and make sure it works